Skip to content

Split airflowctl dags state argument into run_id and --logical-date#69915

Merged
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-dags-state
Jul 24, 2026
Merged

Split airflowctl dags state argument into run_id and --logical-date#69915
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-dags-state

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • Followup from Add airflowctl tasks failed-deps command #69397 (comment).
  • The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
  • If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

  • Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
  • run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

  • uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Comment thread airflow-ctl/src/airflowctl/ctl/commands/dag_command.py Outdated
Comment thread airflow-ctl/src/airflowctl/ctl/commands/dag_command.py Outdated
Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py Outdated
Signed-off-by: PoAn Yang <payang@apache.org>
@Lee-W

Lee-W commented Jul 23, 2026

Copy link
Copy Markdown
Member

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

@bugraoz93 bugraoz93 added the full tests needed We need to run full set of tests for this PR to merge label Jul 23, 2026
@bugraoz93 bugraoz93 closed this Jul 23, 2026
@bugraoz93 bugraoz93 reopened this Jul 23, 2026
@bugraoz93

Copy link
Copy Markdown
Contributor

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

@bugraoz93

Copy link
Copy Markdown
Contributor

Let see CI integration tests and merge :)

@Lee-W
Lee-W merged commit b33558e into apache:main Jul 24, 2026
249 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
airflow-ctl/v0-1-test PR Link

Lee-W pushed a commit that referenced this pull request Jul 24, 2026
…_id and --logical-date (#69915) (#70352)

Co-authored-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 deleted the airflow-dags-state branch July 24, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl backport-to-airflow-ctl/v0-1-test full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants